Fix line accounting for alternateCommentMode#2018
Closed
shicks wants to merge 1 commit intoprotobufjs:masterfrom
Closed
Fix line accounting for alternateCommentMode#2018shicks wants to merge 1 commit intoprotobufjs:masterfrom
alternateCommentMode#2018shicks wants to merge 1 commit intoprotobufjs:masterfrom
Conversation
When `alternateCommentMode` is enabled, the tokenizer treats a block of multiple end-of-line (`//`) comments as a single line when keeping track of line numbers, making error messages very difficult to understand, since they refer to the wrong line number. This change increments the line number in the inner loop, so that each line is accounted correctly.
Author
|
Is anyone maintaining this project? It would be good to get this PR merged so that errors are reported on the correct line. Without this, it's extremely difficult to debug parse errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
alternateCommentModeis enabled, the tokenizer treats a block of multiple end-of-line (//) comments as a single line when keeping track of line numbers, making error messages very difficult to understand, since they refer to the wrong line number.This change increments the line number in the inner loop, so that each line is accounted correctly.
To reproduce the bug:
This reports an error at broken.js line 5, rather than line 9 where the error actually is.